Bug 43 - Support for "Read Sample Offset" feature
Summary: Support for "Read Sample Offset" feature
Status: CONFIRMED
Alias: None
Product: abcde
Classification: Unclassified
Component: Ripping (show other bugs)
Version: unspecified
Hardware: All All
: Normal normal
Assignee: Steve McIntyre
URL:
Depends on:
Blocks:
 
Reported: 2016-09-20 15:10 BST by Chris Chiappa
Modified: 2016-09-20 15:15 BST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Chiappa 2016-09-20 15:10:31 BST

    
Comment 1 Chris Chiappa 2016-09-20 15:14:06 BST
Oops, hit ENTER too fast.

This enhancement request was on the old github (And maybe Google?) issue tracker.  It would be nice to have support for offset in abcde.  The github issue seems to be gone, but is still viewable in the Google cache:
https://webcache.googleusercontent.com/search?q=cache:ycDVmnMbq_UJ:https://github.com/boronology/abcde/issues/131+&cd=5&hl=en&ct=clnk&gl=us
Also potentially  of interest:
http://0f5f.blogs.minster.io/2014/09/precision-audio-ripping-with-abcde/
https://lists.einval.com/pipermail/abcde-users/2013-May/000045.html

Simply adding an offset to the cdparanoia command line may not be strictly correct - on my drive, it seems to cause it to read off the end of the disc, triggering a lot of errors.  Might be worth seeing how rubyripper drives cdparanoia with offsets.
Comment 2 Chris Chiappa 2016-09-20 15:15:33 BST
Relevant parts of the google code/github issue, in case the Google cache goes away:

 GoogleCodeExporter commented Jan 17, 2016

Add the "Read Sample Offset" feature that EAC has as different CD-Rom models 
cannot scan to an exact sector but are always off by a set amount.
The following website can be used to identify sample offset values: 
http://www.accuraterip.com/driveoffsets.htm

What version of the product are you using? On what operating system?

The following suggested code is diff'ed from abcde 2.5.4 (tested on Linux Mint 
17)

Please provide any additional information below.

$ tail -n 3 abcde.conf
# set Read-Sample-Offset value (same as Exact Audio Copy)
# (Currently only used with cdparanoia)
#READSAMPLEOFFSET=0

$ diff  abcde.2.5.4  abcde.ReadSampleOffset
3956a3957,3962
> if [ "${READSAMPLEOFFSET:-0}" != "0" ]; then
>     case "$CDROMREADERSYNTAX" in
>         cdparanoia) CDROMREADEROPTS="$CDPARANOIAOPTS --sample-offset 
$READSAMPLEOFFSET" ;;
>     esac
> fi
> 

The code uses cdparanoia "--sample-offset" command line option. 
I tried testing with icedax "--offset" option but unfortunately this alters the 
start sector but not the end sector (maybe specifying number of sectors with 
"--duration" would work (not tested).

Original issue reported on code.google.com by ahayes...@gmail.com on 25 Feb 2015 at 11:17
@GoogleCodeExporter
GoogleCodeExporter commented Jan 17, 2016

Only issue I see is that as far as I know only cdparanoia has the ability to 
cleanly use the offsets (mind you I have been wrong before...) whereas your 
patch is obviously leaving a space for other cdrom rippers to be added.

And if only cdparanoia the option could be easily added in CDPARANIOOPTS in 
~/.abcde.conf?

Original comment by andrew.d...@gmail.com on 26 Feb 2015 at 9:47