Bug 57 - abcde-musicbrainz-tool bug in release year
Summary: abcde-musicbrainz-tool bug in release year
Status: RESOLVED FIXED
Alias: None
Product: abcde
Classification: Unclassified
Component: CD lookup (show other bugs)
Version: unspecified
Hardware: All All
: Normal normal
Assignee: Steve McIntyre
URL:
: 62 65 74 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-11 19:40 GMT by tecknicaltom
Modified: 2018-02-21 22:19 GMT (History)
4 users (show)

See Also:


Attachments
patch for fix (1.62 KB, patch)
2017-02-11 19:40 GMT, tecknicaltom
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tecknicaltom 2017-02-11 19:40:41 GMT
Created attachment 47 [details]
patch for fix

The fix for #30 implemented in 1f1d33c64206841195a196595ed48f78952c07e6
relies on the release-event-list node from MB containing a count
attribute. However in my testing, that isn't the case, and so the
release year is never populated. This change checks that the
release_event_list isn't undef before trying to get the events (the
cause of the exception in #30) but then doesn't rely on the count() of
the release_event_list.
Comment 1 Steve McIntyre 2018-02-21 21:45:32 GMT
Applied, thanks!
Comment 2 Steve McIntyre 2018-02-21 21:49:53 GMT
*** Bug 62 has been marked as a duplicate of this bug. ***
Comment 3 Steve McIntyre 2018-02-21 22:12:44 GMT
*** Bug 65 has been marked as a duplicate of this bug. ***
Comment 4 Steve McIntyre 2018-02-21 22:19:25 GMT
*** Bug 74 has been marked as a duplicate of this bug. ***