Bug 74 - abcde-musicbrainz-tool fails to extract year from returned XML
Summary: abcde-musicbrainz-tool fails to extract year from returned XML
Status: RESOLVED DUPLICATE of bug 57
Alias: None
Product: abcde
Classification: Unclassified
Component: CD lookup (show other bugs)
Version: unspecified
Hardware: PC Linux
: Normal normal
Assignee: Steve McIntyre
URL:
Depends on:
Blocks:
 
Reported: 2017-12-10 19:20 GMT by Travis Beale
Modified: 2018-02-21 22:46 GMT (History)
2 users (show)

See Also:

Attachments
Patch to fix release year bug in abcde-musicbrainz-tool (488 bytes, patch)
2017-12-10 19:20 GMT, Travis Beale 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Travis Beale 2017-12-10 19:20:45 GMT 
Created attachment 57 [details]
Patch to fix release year bug in abcde-musicbrainz-tool

In abcde-musicbrainz-tool, $rel_year is never set because the existing code expects ($release->release_event_list() to be an array, when really the event array is in $release->release_event_list()->events().

The included patch fixes this.
Comment 1 Steve McIntyre 2018-02-21 22:19:25 GMT 
I *think* we've just fixed this in a slightly different way with the patch in Bug 57.

*** This bug has been marked as a duplicate of bug 57 ***
Comment 2 Travis Beale 2018-02-21 22:46:17 GMT 
(In reply to Steve McIntyre from comment #1)
> I *think* we've just fixed this in a slightly different way with the patch
> in Bug 57.
> 
> *** This bug has been marked as a duplicate of bug 57 ***

For what it's worth, the patch in Bug 57 still failed for me at the time I made my patch.  It fails in cases where the event list object is present, but contains a list with a length of zero.