Bug 97 - submission via musicbrainz website should be easy
Summary: submission via musicbrainz website should be easy
Alias: None
Product: abcde
Classification: Unclassified
Component: CD lookup (show other bugs)
Version: unspecified
Hardware: All All
: Normal enhancement
Assignee: Steve McIntyre
Depends on:
Reported: 2019-05-17 05:55 BST by J.D. Laub
Modified: 2020-11-19 13:01 GMT (History)
2 users (show)

See Also:

patch to print an URL for MB submission (4.29 KB, patch)
2019-05-17 05:55 BST, J.D. Laub
Offers URL to submit a disc not found in musicbrainz (4.14 KB, patch)
2020-11-10 03:18 GMT, J.D. Laub

Note You need to log in before you can comment on or make changes to this bug.
Description J.D. Laub 2019-05-17 05:55:58 BST
Created attachment 76 [details]
patch to print an URL for MB submission

(I proposed this enhancement, oh, 18 or so months ago. It never made it in - I don't recall why - but I continue to exercise this logic VERY frequently in my locally modified copy, and think others could benefit too.)

abcde offers data submission to cddb (via email), but no hooks for submitting to musicbrainz. (MB takes submissions via their website instead of email.) The attached patch will have abcde print an URL for MB submissions. The new behavior is enabled only if a new config variable enables it; without that setting, abcde behavior is unchanged.

It's not a huge change: if the MB lookup fails, and if the config turns it on, then prompt the user if they'd like to submit to MB via their website. If the user accepts the default of "N", then proceed on to the existing logic ("Edit selected CDDB data [y/N]?"); if the user instead answers "y" to the MB submission question, then print an URL for the MB website (which the user can optionally visit however they wish), and then wait for the user to acknowledge MB has been updated before looping back to attempt the lookup again.

It's important to point out that it's not a generic URL that's offered, but one specific to the disc; it facilitates the submission process with the proper disc TOC. It's been my personal experience that more often than not, it's just a matter of attaching the current TOC to an existing MB entry, avoiding significant data entry.

Here's a quick session demonstrating the logic. Here, I choose *not* to to actually submit my disk info to MB, so the 2nd lookup also fails; at that point I decline the offer to submit, and existing logic resumes. (Normally, the 2nd lookup would succeed.)
    $ abcde
    Grabbing entire CD - tracks:  01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19
    MusicBrainz lookup returned an error "Not Found"
    Submit via http [y/N]? y
    Visit http://musicbrainz.org/cdtoc/attach?id=&tracks=19&toc=1+19+256522+150+13938+29621+35837+51400+58890+72036+88984+92152+109367+121795+136973+141854+146914+165165+181118+194786+213831+235197
    ... then hit enter to retry lookup. Waiting...
    MusicBrainz lookup returned an error "Not Found"
    Submit via http [y/N]?
    Selected: # (template) (Unknown Artist / Unknown Album)
    ---- Unknown Artist / Unknown Album ----
    1: Track 1
    2: Track 2

I'm happy to rework any of this.
Comment 1 J.D. Laub 2020-11-10 03:18:45 GMT
Created attachment 132 [details]
Offers URL to submit a disc not found in musicbrainz

Compared to the prior version submitted ~18 months ago, this has been refactored so that 1) abcde-musicbrainz-tool now exposes existing functionality of the Perl module MusicBrainz::DiscID , and 2) abcde now invokes the new abcde-musicbrainz-tool functionality instead of generating the URL itself.
Comment 2 Christian Weiske 2020-11-19 13:01:01 GMT
The patch works fine!

I'd just like OFFERMBURL to default to "y".