Bug 87 - Fails to handle URLs of type file://
Summary: Fails to handle URLs of type file://
Status: CONFIRMED
Alias: None
Product: abcde
Classification: Unclassified
Component: Album art (show other bugs)
Version: unspecified
Hardware: All All
: Normal normal
Assignee: Andrew Strong
URL:
Depends on:
Blocks:
 
Reported: 2018-08-10 23:43 BST by fleury
Modified: 2018-08-10 23:58 BST (History)
1 user (show)

See Also:

Attachments
Simply handles file:// as it does paths without that protocol. (911 bytes, patch)
2018-08-10 23:43 BST, fleury 		Details
Simple improvement of the prompt for the URL. (442 bytes, patch)
2018-08-10 23:58 BST, fleury 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fleury 2018-08-10 23:43:09 BST 
Created attachment 66 [details]
Simply handles file:// as it does paths without that protocol.

when getting the AlbumArt URL, it will fail to use e.g. 'file:///my/path/to/image.jpg' because 'wget' does not handle that protocol (any more?).

My system:
Ubuntu 18.04.1 LTS (bionic)
abcde 2.8.1-1

I think the solution should be as simple as not handling file:// through wget, but just strip 'file://' and get the path that way. I am not sure how this will work on systems like OSX or Windows, if these are supported though.

I attached a patch off commit 8de69dd9476d40b4d61b25532f0a22acd932d765 in the hope of simplifying its use, but it's straight forward.
Comment 1 fleury 2018-08-10 23:58:01 BST 
Created attachment 67 [details]
Simple improvement of the prompt for the URL.

This just moves the ':' so it has a space after it, feels more natural to me when entering data on the console